Commit e463b487c69 for nodejs
commit e463b487c69d1ef482a407d55410498164c0892c
Author: Yuya Inoue <65857152+inoway46@users.noreply.github.com>
Date: Sun Oct 18 22:32:15 2026 +0900
build: fail Windows CI on missing GYP sources
Enable the existing GYP missing-source check in the Windows coverage
workflow so stale references fail project generation instead of
only producing warnings.
Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66787
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml
index beffb26f3ec..a489a2cde2a 100644
--- a/.github/workflows/coverage-windows.yml
+++ b/.github/workflows/coverage-windows.yml
@@ -88,6 +88,8 @@ jobs:
rustup --version
- name: Build
run: ./vcbuild.bat clang-cl v8temporal
+ env:
+ config_flags: -Gmsvs_error_on_missing_sources=1
# TODO(bcoe): investigate tests that fail with coverage enabled
# on Windows.
- name: Test