Commit e6d624b9a for llama.cpp
commit e6d624b9a4b95c6b52f5ca384d70b75581f9821a
Author: saiph <cecwxf@126.com>
Date: Sun Nov 22 02:05:02 2026 +0800
mtmd : merge Parakeet rel-pos views to avoid OOB (#32722)
Assisted-by: Grok Bot
diff --git a/tools/mtmd/models/parakeet.cpp b/tools/mtmd/models/parakeet.cpp
index 4a2377b4c..a989e5839 100644
--- a/tools/mtmd/models/parakeet.cpp
+++ b/tools/mtmd/models/parakeet.cpp
@@ -296,23 +296,16 @@ ggml_cgraph * mtmd_graph_parakeet::build() {
int center = pos_window / 2;
size_t offset = rel_pos_scores->nb[0] * (center+1);
- rel_pos_scores = ggml_view_3d(ctx0, rel_pos_scores,
- n_frame, pos_window, n_head,
- (pos_window) * 4,
- rel_pos_scores->nb[2],
- offset);
- rel_pos_scores = ggml_cont(ctx0, rel_pos_scores);
- ggml_format_name(rel_pos_scores, "enc_%d_attn_rel_pos_shifted", il);
-
+ // nb1 is the diagonal-extraction stride, not the source row stride
rel_pos_scores = ggml_view_3d(ctx0, rel_pos_scores,
content_scores->ne[0],
content_scores->ne[1],
- rel_pos_scores->ne[2],
- rel_pos_scores->nb[1],
+ n_head,
+ (size_t) pos_window * rel_pos_scores->nb[0],
rel_pos_scores->nb[2],
- 0);
+ offset);
rel_pos_scores = ggml_cont(ctx0, rel_pos_scores);
- ggml_format_name(rel_pos_scores, "enc_%d_attn_rel_pos_shifted_view", il);
+ ggml_format_name(rel_pos_scores, "enc_%d_attn_rel_pos_shifted", il);
}
struct ggml_tensor * attn_scores = ggml_add(ctx0, content_scores, rel_pos_scores);