Commit f4f41c4772 for bind
commit f4f41c477231ca55723c00a65f1ec3b7fab450d6
Author: Martin Basti <mbasti@isc.org>
Date: Fri Oct 30 19:31:17 2026 +0000
Make the dnstap dispatch address test query ns3 again
Commit bfe338b965 switched the query in
test_dnstap_dispatch_socket_addresses from ns3 to ns2 while replacing
dns.resolver. ns3 then logs no resolver traffic, the test inspects
zero frames and passes vacuously. Query ns3 again and fail when no
resolver frame was captured, so this cannot happen silently.
diff --git a/bin/tests/system/dnstap/tests_dnstap.py b/bin/tests/system/dnstap/tests_dnstap.py
index f5ff8c6223..f9eca104ef 100644
--- a/bin/tests/system/dnstap/tests_dnstap.py
+++ b/bin/tests/system/dnstap/tests_dnstap.py
@@ -34,7 +34,7 @@ pytestmark = [
def test_dnstap_dispatch_socket_addresses(ns3):
# Send some query to ns3 so that it records something in its dnstap file.
msg = isctest.query.create("mail.example.", "A")
- res = isctest.query.tcp(msg, "10.53.0.2", expected_rcode=dns.rcode.NOERROR)
+ res = isctest.query.tcp(msg, ns3.ip, expected_rcode=dns.rcode.NOERROR)
assert res.answer == [
dns.rrset.from_text("mail.example.", 300, "IN", "A", "10.0.0.2")
]
@@ -71,6 +71,7 @@ def test_dnstap_dispatch_socket_addresses(ns3):
if not re.match(addr_regex, addr1) or not re.match(addr_regex, addr2):
bad_frames.append(line)
+ assert inspected_frames > 0, "no resolver frames were captured"
assert (
len(bad_frames) == 0
), "{} out of {} inspected frames contain unexpected addresses:\n\n{}".format(