Commit f73e43199e for bind
commit f73e43199ed696a154fd316379fb2e13db4fa830
Author: Alessio Podda <alessio@isc.org>
Date: Thu Sep 10 11:58:23 2026 +0200
Fix scan-build
The dns_linkedname_name upcasting confuses scan-build, since it
doesn't know that dns_message_gettempname() always returns a non-NULL
pointer. Help scan-build by adding an appropriate NULL check.
diff --git a/lib/dns/sdlz.c b/lib/dns/sdlz.c
index e1c2b78eda..5abaf614fe 100644
--- a/lib/dns/sdlz.c
+++ b/lib/dns/sdlz.c
@@ -1102,16 +1102,14 @@ sdlz_addglue_addr(sdlz_addglue_ctx_t *ctx, dns_dbnode_t *node,
dns_message_gettemprdataset(ctx->msg, &rdataset);
- result = findrdataset((dns_db_t *)ctx->sdlz, node, ctx->version, type,
- 0, 0, rdataset, NULL DNS__DB_FLARG_PASS);
- if (result != ISC_R_SUCCESS) {
- goto cleanup;
- }
+ CHECK(findrdataset((dns_db_t *)ctx->sdlz, node, ctx->version, type, 0,
+ 0, rdataset, NULL DNS__DB_FLARG_PASS));
if (*mnamep == NULL) {
dns_sdlznode_t *sdlznode = (dns_sdlznode_t *)node;
dns_message_gettempname(ctx->msg, mnamep);
+ INSIST(*mnamep != NULL);
dns_name_copy(&sdlznode->name, dns_linkedname_name(*mnamep));
}