Commit 09bdd12f for libheif
commit 09bdd12fe420cac46f822b829e1814e9de915491
Author: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
Date: Mon Aug 10 17:17:53 2026 +0200
Do not propagate compile macros in public interface
`HAVE_BROTLI` and `HAVE_LIBSHARPYUV` should not appear in the public interface, just like `HAVE_ZLIB` already.
Will need to be added where actually used: examples and tests.
diff --git a/libheif/CMakeLists.txt b/libheif/CMakeLists.txt
index 6f6bda27..bddfc6e6 100644
--- a/libheif/CMakeLists.txt
+++ b/libheif/CMakeLists.txt
@@ -264,7 +264,7 @@ add_subdirectory(plugins)
if (LIBSHARPYUV_FOUND)
message("Compiling in 'libsharpyuv'")
- target_compile_definitions(heif PUBLIC HAVE_LIBSHARPYUV=1)
+ target_compile_definitions(heif PRIVATE HAVE_LIBSHARPYUV=1)
target_include_directories(heif PRIVATE ${LIBSHARPYUV_INCLUDE_DIRS})
target_link_libraries(heif PRIVATE ${LIBSHARPYUV_LIBRARIES})
else ()
@@ -277,7 +277,7 @@ if (ZLIB_FOUND)
endif ()
if (Brotli_FOUND)
- target_compile_definitions(heif PUBLIC HAVE_BROTLI=1)
+ target_compile_definitions(heif PRIVATE HAVE_BROTLI=1)
target_include_directories(heif PRIVATE ${BROTLI_INCLUDE_DIRS})
target_link_libraries(heif PRIVATE ${BROTLI_LIBS})
endif()