Commit 10b0340fec for openssl.org
commit 10b0340feccff0a50ee9ed888645a7e93163516e
Author: herbenderbler <johnclaus@gmail.com>
Date: Sat Mar 14 17:34:03 2026 -0600
Remove unused vpaes_ecb_decrypt from ARMv8 vpaes assembly
vpaes_ecb_decrypt in vpaes-armv8.pl was never referenced. It also
contained a bug: the single-block path called _vpaes_encrypt_core
instead of _vpaes_decrypt_core. Delete the dead function.
Resolves: https://github.com/openssl/openssl/issues/30341
CLA: trivial
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
MergeDate: Thu Mar 19 20:36:27 2026
(Merged from https://github.com/openssl/openssl/pull/30423)
diff --git a/crypto/aes/asm/vpaes-armv8.pl b/crypto/aes/asm/vpaes-armv8.pl
index a8cc8c3f78..1e348aafc7 100755
--- a/crypto/aes/asm/vpaes-armv8.pl
+++ b/crypto/aes/asm/vpaes-armv8.pl
@@ -1254,48 +1254,6 @@ vpaes_ecb_encrypt:
AARCH64_VALIDATE_LINK_REGISTER
ret
.size vpaes_ecb_encrypt,.-vpaes_ecb_encrypt
-
-.globl vpaes_ecb_decrypt
-.type vpaes_ecb_decrypt,%function
-.align 4
-vpaes_ecb_decrypt:
- AARCH64_SIGN_LINK_REGISTER
- stp x29,x30,[sp,#-16]!
- add x29,sp,#0
- stp d8,d9,[sp,#-16]! // ABI spec says so
- stp d10,d11,[sp,#-16]!
- stp d12,d13,[sp,#-16]!
- stp d14,d15,[sp,#-16]!
-
- mov x17, $len
- mov x2, $key
- bl _vpaes_decrypt_preheat
- tst x17, #16
- b.eq .Lecb_dec_loop
-
- ld1 {v7.16b}, [$inp],#16
- bl _vpaes_encrypt_core
- st1 {v0.16b}, [$out],#16
- subs x17, x17, #16
- b.ls .Lecb_dec_done
-
-.align 4
-.Lecb_dec_loop:
- ld1 {v14.16b,v15.16b}, [$inp], #32
- bl _vpaes_decrypt_2x
- st1 {v0.16b,v1.16b}, [$out], #32
- subs x17, x17, #32
- b.hi .Lecb_dec_loop
-
-.Lecb_dec_done:
- ldp d14,d15,[sp],#16
- ldp d12,d13,[sp],#16
- ldp d10,d11,[sp],#16
- ldp d8,d9,[sp],#16
- ldp x29,x30,[sp],#16
- AARCH64_VALIDATE_LINK_REGISTER
- ret
-.size vpaes_ecb_decrypt,.-vpaes_ecb_decrypt
___
} }
print $code;