Commit 11a4f9576a for qemu.org
commit 11a4f9576ad5d0581aa90ee393168c52ed4bce89
Author: Jamin Lin <jamin_lin@aspeedtech.com>
Date: Mon Jun 1 02:50:32 2026 +0000
hw/pci-host/aspeed_pcie: Convert to DEFINE_TYPES() with inlined TypeInfo
Replace the legacy type_register_static()/type_init() registration
pattern with the modern DEFINE_TYPES() macro.
Inline 6 standalone TypeInfo variables (aspeed_pcie_phy_info, aspeed_2700_pcie_phy_info
aspeed_pcie_root_port_info, aspeed_pcie_rc_info, aspeed_pcie_cfg_info and
aspeed_2700_pcie_cfg_info directly into the 'aspeed_pcie_types[]'
array, removing the need for separate declarations.
No functional change.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260601024959.2347639-22-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 186e5aeea2..b46eb74234 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -83,13 +83,6 @@ static void aspeed_pcie_root_port_class_init(ObjectClass *klass,
rpc->ssid = 0x1150;
}
-static const TypeInfo aspeed_pcie_root_port_info = {
- .name = TYPE_ASPEED_PCIE_ROOT_PORT,
- .parent = TYPE_PCIE_ROOT_PORT,
- .instance_size = sizeof(AspeedPCIERootPortState),
- .class_init = aspeed_pcie_root_port_class_init,
-};
-
/*
* PCIe Root Complex (RC)
*/
@@ -305,14 +298,6 @@ static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
msi_nonbroken = true;
}
-static const TypeInfo aspeed_pcie_rc_info = {
- .name = TYPE_ASPEED_PCIE_RC,
- .parent = TYPE_PCIE_HOST_BRIDGE,
- .instance_size = sizeof(AspeedPCIERcState),
- .instance_init = aspeed_pcie_rc_instance_init,
- .class_init = aspeed_pcie_rc_class_init,
-};
-
/*
* PCIe Config
*
@@ -679,15 +664,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
apc->rc_rp_addr = PCI_DEVFN(8, 0);
}
-static const TypeInfo aspeed_pcie_cfg_info = {
- .name = TYPE_ASPEED_PCIE_CFG,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_init = aspeed_pcie_cfg_instance_init,
- .instance_size = sizeof(AspeedPCIECfgState),
- .class_init = aspeed_pcie_cfg_class_init,
- .class_size = sizeof(AspeedPCIECfgClass),
-};
-
static void aspeed_2700_pcie_cfg_write(void *opaque, hwaddr addr,
uint64_t data, unsigned int size)
{
@@ -798,12 +774,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,
apc->rc_rp_addr = PCI_DEVFN(0, 0);
}
-static const TypeInfo aspeed_2700_pcie_cfg_info = {
- .name = TYPE_ASPEED_2700_PCIE_CFG,
- .parent = TYPE_ASPEED_PCIE_CFG,
- .class_init = aspeed_2700_pcie_cfg_class_init,
-};
-
/*
* PCIe PHY
*
@@ -926,14 +896,6 @@ static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void *data)
apc->nr_regs = 0x100 >> 2;
}
-static const TypeInfo aspeed_pcie_phy_info = {
- .name = TYPE_ASPEED_PCIE_PHY,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(AspeedPCIEPhyState),
- .class_init = aspeed_pcie_phy_class_init,
- .class_size = sizeof(AspeedPCIEPhyClass),
-};
-
static void aspeed_2700_pcie_phy_reset_hold(Object *obj, ResetType type)
{
AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(obj);
@@ -961,21 +923,47 @@ static void aspeed_2700_pcie_phy_class_init(ObjectClass *klass,
apc->nr_regs = 0x800 >> 2;
}
-static const TypeInfo aspeed_2700_pcie_phy_info = {
- .name = TYPE_ASPEED_2700_PCIE_PHY,
- .parent = TYPE_ASPEED_PCIE_PHY,
- .class_init = aspeed_2700_pcie_phy_class_init,
-};
+static const TypeInfo aspeed_pcie_types[] = {
+ {
+ .name = TYPE_ASPEED_PCIE_RC,
+ .parent = TYPE_PCIE_HOST_BRIDGE,
+ .instance_size = sizeof(AspeedPCIERcState),
+ .instance_init = aspeed_pcie_rc_instance_init,
+ .class_init = aspeed_pcie_rc_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_ROOT_PORT,
+ .parent = TYPE_PCIE_ROOT_PORT,
+ .instance_size = sizeof(AspeedPCIERootPortState),
+ .class_init = aspeed_pcie_root_port_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_CFG,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_init = aspeed_pcie_cfg_instance_init,
+ .instance_size = sizeof(AspeedPCIECfgState),
+ .class_init = aspeed_pcie_cfg_class_init,
+ .class_size = sizeof(AspeedPCIECfgClass),
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_PHY,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_size = sizeof(AspeedPCIEPhyState),
+ .class_init = aspeed_pcie_phy_class_init,
+ .class_size = sizeof(AspeedPCIEPhyClass),
+ },
+ {
+ .name = TYPE_ASPEED_2700_PCIE_PHY,
+ .parent = TYPE_ASPEED_PCIE_PHY,
+ .class_init = aspeed_2700_pcie_phy_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_2700_PCIE_CFG,
+ .parent = TYPE_ASPEED_PCIE_CFG,
+ .class_init = aspeed_2700_pcie_cfg_class_init,
+ }
-static void aspeed_pcie_register_types(void)
-{
- type_register_static(&aspeed_pcie_rc_info);
- type_register_static(&aspeed_pcie_root_port_info);
- type_register_static(&aspeed_pcie_cfg_info);
- type_register_static(&aspeed_2700_pcie_cfg_info);
- type_register_static(&aspeed_pcie_phy_info);
- type_register_static(&aspeed_2700_pcie_phy_info);
-}
+};
-type_init(aspeed_pcie_register_types);
+DEFINE_TYPES(aspeed_pcie_types)