Commit 237916a30d for openssl.org
commit 237916a30d4925f72f55e5358e5caf7e104da172
Author: Milan Broz <gmazyland@gmail.com>
Date: Wed Apr 22 15:00:49 2026 +0200
Fix signed/unsigned comparison under MINGW64
SOCKET is unsigned on Windows, these is no need to cast
parameter. INVALID_SOCKET test should work on all platforms.
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Thu Apr 30 11:42:20 2026
(Merged from https://github.com/openssl/openssl/pull/30941)
diff --git a/crypto/bio/bio_sock.c b/crypto/bio/bio_sock.c
index 5b793b9af1..44e8f622ae 100644
--- a/crypto/bio/bio_sock.c
+++ b/crypto/bio/bio_sock.c
@@ -437,7 +437,7 @@ int BIO_socket_wait(int fd, int for_read, time_t max_time)
time_t now;
#ifdef _WIN32
- if ((SOCKET)fd == INVALID_SOCKET)
+ if (fd == INVALID_SOCKET)
#else
if (fd < 0 || fd >= FD_SETSIZE)
#endif