Commit 35f2e885cd3 for php.net
commit 35f2e885cd3db49a072303e1966f3d64e16d65e3
Author: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Date: Thu Jul 2 14:36:15 2026 -0700
Simplify `ReflectionProperty::getSettableType()` property handling
Once the `property_reference` has been dereferenced to identify the
`zend_property_info`, no need to do so again since the result was already
stored in a variable.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index 54f420b3cb0..7dc65d09cc2 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -6426,7 +6426,7 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
const zend_property_info *prop = ref->prop;
/* Dynamic property is untyped. */
- if (!ref->prop) {
+ if (!prop) {
RETURN_NULL();
}
@@ -6448,10 +6448,10 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
}
/* Fall back to property type */
- if (!ZEND_TYPE_IS_SET(ref->prop->type)) {
+ if (!ZEND_TYPE_IS_SET(prop->type)) {
RETURN_NULL();
}
- reflection_type_factory(ref->prop->type, return_value, true);
+ reflection_type_factory(prop->type, return_value, true);
}
/* {{{ Returns whether property has a type */