Commit 52a9a4f247 for openssl.org
commit 52a9a4f24750ef15a23343729acad71942c5bc55
Author: Bob Beck <beck@openssl.org>
Date: Wed Aug 5 09:54:47 2026 -0600
Don't call strlcpy on a non-string.
Again, ASN1_STRING_get0_data has never been guaranteed to be nul terminated.
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Andrew Dinh <andrewd@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Merge-date: Thu Aug 27 13:52:40 2026
Merged-from: https://github.com/openssl/openssl/pull/32178
diff --git a/apps/ca.c b/apps/ca.c
index 1c42a2dfe0..4fb4fe3d74 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -2428,7 +2428,8 @@ static char *make_revocation_str(REVINFO_TYPE rev_type, const char *rev_arg)
i += strlen(other) + 1;
str = app_malloc(i, "revocation reason");
- OPENSSL_strlcpy(str, (const char *)ASN1_STRING_get0_data(revtm), i);
+ BIO_snprintf(str, i, "%.*s", (int)ASN1_STRING_get_length(revtm),
+ (const char *)ASN1_STRING_get0_data(revtm));
if (reason) {
OPENSSL_strlcat(str, ",", i);
OPENSSL_strlcat(str, reason, i);