Commit 58e0580ab8 for qemu.org
commit 58e0580ab88cf133d28ff93be150524375eb29c2
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Tue Feb 24 17:32:29 2026 +0100
audio/mixeng: drop some needless checks
The NULL checks for be, name, callback_fn, and as in
audio_mixeng_backend_open_{in,out} are redundant: the callers
audio_be_open_{in,out} already assert that name, callback_fn, and as
are non-NULL, and dereference be unconditionally via
AUDIO_BACKEND_GET_CLASS(be) before the call.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20260224163229.2918858-1-marcandre.lureau@redhat.com>
diff --git a/audio/audio_template.h b/audio/audio_template.h
index 228369cf9a..fe769cde66 100644
--- a/audio/audio_template.h
+++ b/audio/audio_template.h
@@ -497,12 +497,6 @@ static SW *glue(audio_mixeng_backend_open_, TYPE) (
AudioMixengBackendClass *k;
AudiodevPerDirectionOptions *pdo;
- if (!be || !name || !callback_fn || !as) {
- audio_bug("backend=%p name=%p callback_fn=%p as=%p",
- be, name, callback_fn, as);
- goto fail;
- }
-
k = AUDIO_MIXENG_BACKEND_GET_CLASS(s);
pdo = glue(audio_get_pdo_, TYPE)(s->dev);