Commit 5ce32f7fdb for qemu.org
commit 5ce32f7fdb786014255d4cfff749de307cdfdbfa
Author: Ani Sinha <anisinha@redhat.com>
Date: Tue Aug 25 18:11:39 2026 +0530
hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op
The control bits define the behavior of the interface and clearing the bits
upon reading or select operation will break that behavior. For example, after
CTL_HOST_IGVM is set by the guest through a write and then subsequently, if the
guest tried to read back the values from the fw-cfg interface, the read would
clear CTL_HOST_IGVM. This would break restoring the host IGVM upon subsequent
reset.
Fixes: 30688c02a76e50e4 ("hw/misc/vmlaunchupdate: Introduce hypervisor fw-cfg interface support")
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Message-ID: <20260825124139.6900-1-anisinha@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
diff --git a/hw/misc/vmlaunchupdate.c b/hw/misc/vmlaunchupdate.c
index afa2d278ae..847d2d963f 100644
--- a/hw/misc/vmlaunchupdate.c
+++ b/hw/misc/vmlaunchupdate.c
@@ -41,7 +41,6 @@ static bool vmlaunchupdate_supported(void)
static void init_vm_launch_update(VMLaunchUpdateState *s)
{
s->launch_update.capabilities = VM_LAUNCHUPDATE_FORMAT_IGVM;
- s->launch_update.control = 0;
if (s->disabled) {
s->launch_update.control |= VM_LAUNCHUPDATE_CTL_DISABLE;