Commit 773400d366 for openssl.org
commit 773400d3664570e276a8016110ae0c75da98065e
Author: dannyward630 <djwarding888@gmail.com>
Date: Thu Jun 18 19:44:01 2026 +0200
crypto/ec/curve448/eddsa.c: document Ed448 property query parameter
Document the propq argument in the Ed448 key generation, signing,
and verification helper comments.
CLA: trivial
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
MergeDate: Wed Jun 24 11:00:00 2026
(Merged from https://github.com/openssl/openssl/pull/31599)
diff --git a/crypto/ec/curve448/eddsa.c b/crypto/ec/curve448/eddsa.c
index 8615b19dfc..1c375413ab 100644
--- a/crypto/ec/curve448/eddsa.c
+++ b/crypto/ec/curve448/eddsa.c
@@ -1,5 +1,5 @@
/*
- * Copyright 2017-2024 The OpenSSL Project Authors. All Rights Reserved.
+ * Copyright 2017-2026 The OpenSSL Project Authors. All Rights Reserved.
* Copyright 2015-2016 Cryptography Research, Inc.
*
* Licensed under the Apache License 2.0 (the "License"). You may not use
@@ -94,6 +94,7 @@ static c448_error_t hash_init_with_dom(OSSL_LIB_CTX *ctx, EVP_MD_CTX *hashctx,
*
* pubkey (out): The public key.
* privkey (in): The private key.
+ * propq (in): The property query used to fetch SHAKE256.
*/
static c448_error_t
c448_ed448_derive_public_key(
@@ -155,6 +156,7 @@ c448_ed448_derive_public_key(
* you want to sign.
* context (in): A "context" for this signature of up to 255 bytes.
* context_len (in): Length of the context.
+ * propq (in): The property query used to fetch SHAKE256.
*
* For Ed25519, it is unsafe to use the same key for both prehashed and
* non-prehashed messages, at least without some very careful protocol-level
@@ -292,6 +294,7 @@ c448_ed448_pubkey_verify(const uint8_t *pub, size_t pub_len)
* want to verify.
* context (in): A "context" for this signature of up to 255 bytes.
* context_len (in): Length of the context.
+ * propq (in): The property query used to fetch SHAKE256.
*
* For Ed25519, it is unsafe to use the same key for both prehashed and
* non-prehashed messages, at least without some very careful protocol-level