Commit 8b031ea6eda for php.net
commit 8b031ea6eda1b9c5bc3e8db479bbaf6283c1511f
Author: Nora Dossche <7771979+ndossche@users.noreply.github.com>
Date: Sat Jan 24 19:15:10 2026 +0100
Fix error check on X509_set_subject_name()
This call can fail but this is not checked. The other setter call is
checked however.
Closes GH-21028.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
index 3dd58f5591a..46047448822 100644
--- a/ext/openssl/openssl.c
+++ b/ext/openssl/openssl.c
@@ -3376,7 +3376,10 @@ PHP_FUNCTION(openssl_csr_sign)
PHP_OPENSSL_ASN1_INTEGER_set(X509_get_serialNumber(new_cert), serial);
}
- X509_set_subject_name(new_cert, X509_REQ_get_subject_name(csr));
+ if (!X509_set_subject_name(new_cert, X509_REQ_get_subject_name(csr))) {
+ php_openssl_store_errors();
+ goto cleanup;
+ }
if (cert == NULL) {
cert = new_cert;