Commit 9130e284e4 for qemu.org
commit 9130e284e4e8fdca7994bafe313dc69a03f5f5a5
Author: Bin Meng <bin.meng@processmission.com>
Date: Sun Aug 16 21:12:34 2026 +0800
hw/arm: collie: Store boot info in the machine state
arm_load_kernel() keeps a pointer to the boot info struct for the
lifetime of the VM, so the struct logically belongs to the machine
rather than to a file scoped static object.
Move the boot info into the existing CollieMachineState.
As in the xlnx-zcu102 and raspi machines, the boot info belongs to
the machine rather than to a static object:
4d1ac883a7 ("hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102")
0f15c6e338 ("hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState")
Signed-off-by: Bin Meng <bin.meng@processmission.com>
Message-id: 20260816131300.51799-5-bin.meng@processmission.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
diff --git a/hw/arm/collie.c b/hw/arm/collie.c
index 91f0a94b6f..01d74ad38c 100644
--- a/hw/arm/collie.c
+++ b/hw/arm/collie.c
@@ -30,16 +30,12 @@ struct CollieMachineState {
MachineState parent;
StrongARMState *sa1110;
+ struct arm_boot_info bootinfo;
};
#define TYPE_COLLIE_MACHINE MACHINE_TYPE_NAME("collie")
OBJECT_DECLARE_SIMPLE_TYPE(CollieMachineState, COLLIE_MACHINE)
-static struct arm_boot_info collie_binfo = {
- .loader_start = SA_SDCS0,
- .ram_size = RAM_SIZE,
-};
-
static void collie_init(MachineState *machine)
{
MachineClass *mc = MACHINE_GET_CLASS(machine);
@@ -66,8 +62,10 @@ static void collie_init(MachineState *machine)
sysbus_create_simple("scoop", 0x40800000, NULL);
- collie_binfo.board_id = 0x208;
- arm_load_kernel(cms->sa1110->cpu, machine, &collie_binfo);
+ cms->bootinfo.loader_start = SA_SDCS0;
+ cms->bootinfo.ram_size = RAM_SIZE;
+ cms->bootinfo.board_id = 0x208;
+ arm_load_kernel(cms->sa1110->cpu, machine, &cms->bootinfo);
}
static void collie_machine_class_init(ObjectClass *oc, const void *data)