Commit a32011d667 for openssl.org
commit a32011d667cd7a35b3931034706716f304faf947
Author: Matt Caswell <matt@openssl.foundation>
Date: Mon Aug 10 16:02:37 2026 +0100
DTLS 1.3 Name the accept flag in the no-BIO test comments
Both tests describe themselves in terms of "blocking mode" and
"non-blocking behaviour", when what they actually vary is the
SSL_ACCEPT_CONNECTION_NO_BLOCK flag. That reads as though they concern a
mode on the object, which invites confusion with
SSL_set_blocking_mode(). Name the flag, and say what each case is really
asserting.
Comment only, no functional change.
Assisted-by: Claude Code:claude-opus-5
Reviewed-by: Ryan Hooper <ryanh@openssl.foundation>
Reviewed-by: Jakub Zelenka <jakub.zelenka@openssl.foundation>
Merge-date: Mon Aug 17 08:29:53 2026
Merged-from: https://github.com/openssl/openssl/pull/32324
diff --git a/test/dtlsssllistenertest.c b/test/dtlsssllistenertest.c
index 5c797bdf48..52ee3e8b2b 100644
--- a/test/dtlsssllistenertest.c
+++ b/test/dtlsssllistenertest.c
@@ -740,9 +740,10 @@ err:
}
/*
- * Test SSL_accept_connection with no net_bio and NO_BLOCK flag.
- * When there is no BIO set and the caller requests non-blocking behaviour,
- * the function must return NULL immediately without raising an error.
+ * Test SSL_accept_connection with no net_bio and the
+ * SSL_ACCEPT_CONNECTION_NO_BLOCK flag, so that the caller is not asking to
+ * wait. The function must return NULL immediately without raising an error,
+ * the absence of a BIO being indistinguishable from having nothing queued.
*/
static int test_dtls_accept_connection_no_bio_no_block(void)
{
@@ -784,9 +785,10 @@ err:
}
/*
- * Test SSL_accept_connection with no net_bio and blocking mode (no NO_BLOCK).
- * When there is no BIO and the caller wants to block, the function must return
- * NULL and raise SSL_R_BIO_NOT_SET.
+ * Test SSL_accept_connection with no net_bio and without the
+ * SSL_ACCEPT_CONNECTION_NO_BLOCK flag, so that the caller is asking to wait.
+ * When there is no BIO the function must return NULL and raise
+ * SSL_R_BIO_NOT_SET rather than waiting, since nothing could ever arrive.
*/
static int test_dtls_accept_connection_no_bio_block(void)
{