Commit ab89d02dac for qemu.org
commit ab89d02dac6f0f53e35a689f01099602aa2de816
Author: GuoHan Zhao <zhaoguohan@kylinos.cn>
Date: Fri May 22 16:13:05 2026 +0800
vfio-user: reject zero DMA page size capability
check_pgsizes() validates that no page-size bits smaller than
VFIO_USER_DEF_PGSIZE are set, but it still accepts pgsizes=0. This lets a
malformed server overwrite the default page-size mask with zero.
Later vfio_user_setup() asserts that proxy->dma_pgsizes is non-zero, so device
realization aborts instead of reporting a version capability error. Reject a
zero DMA page-size mask during version capability parsing.
Fixes: 36227628d824 (vfio-user: implement message send infrastructure)
Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
Reviewed-by: John Levon <john.levon@nutanix.com>
Link: https://lore.kernel.org/qemu-devel/20260522081306.4186242-1-zhaoguohan@kylinos.cn
Signed-off-by: Cédric Le Goater <clg@redhat.com>
diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c
index e02a45e997..be2601d5ec 100644
--- a/hw/vfio-user/proxy.c
+++ b/hw/vfio-user/proxy.c
@@ -1155,9 +1155,11 @@ static bool check_pgsizes(VFIOUserProxy *proxy, QObject *qobj, Error **errp)
return false;
}
- /* must be larger than default */
- if (pgsizes & (VFIO_USER_DEF_PGSIZE - 1)) {
- error_setg(errp, "pgsize 0x%"PRIx64" too small", pgsizes);
+ /* must not be zero or smaller than default */
+ if (pgsizes < VFIO_USER_DEF_PGSIZE ||
+ (pgsizes & (VFIO_USER_DEF_PGSIZE - 1))) {
+ error_setg(errp, "%s 0x%"PRIx64" too small",
+ VFIO_USER_CAP_PGSIZES, pgsizes);
return false;
}