Commit b6a6d91b9e for qemu.org
commit b6a6d91b9e5ebe32c31ca1510a87077a586d9923
Author: Aadeshveer Singh <aadeshveer07@gmail.com>
Date: Mon Mar 16 19:15:09 2026 +0530
migration: fix implicit integer division in migration_update_counters
switchover_bw is a uint64_t, so switchover_bw / 1000 results in an
integer division. This value is then assigned to expected_bw_per_ms
which is of type double. This results in losing precision and is type
unsafe. Adding explicit cast ensures floating-point division.
Signed-off-by: Aadeshveer Singh <aadeshveer07@gmail.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260316134509.157964-1-aadeshveer07@gmail.com
Signed-off-by: Fabiano Rosas <farosas@suse.de>
diff --git a/migration/migration.c b/migration/migration.c
index 7feeba804f..5c9aaa6e58 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3141,7 +3141,7 @@ static void migration_update_counters(MigrationState *s,
* If the user specified a switchover bandwidth, let's trust the
* user so that can be more accurate than what we estimated.
*/
- expected_bw_per_ms = switchover_bw / 1000;
+ expected_bw_per_ms = (double)switchover_bw / 1000;
} else {
/* If the user doesn't specify bandwidth, we use the estimated */
expected_bw_per_ms = bandwidth;