Commit c347711ea7 for qemu.org
commit c347711ea7f5b9cbcd558ecfaa81988e0baff359
Author: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Date: Wed Jul 29 12:31:42 2026 +0300
tests/functional/qemu_test: drop *args argument from .get_vm()
It's redundant. Only one caller use it, and it may be simply
substituted by .add_args().
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260729093146.1893719-3-vsementsov@yandex-team.ru>
Signed-off-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/functional/migration.py b/tests/functional/migration.py
index 4344e03be4..8d2428efc2 100644
--- a/tests/functional/migration.py
+++ b/tests/functional/migration.py
@@ -63,7 +63,8 @@ def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm):
self.assert_dest_vm(dst_vm)
def migrate(self, dst_uri, src_uri=None):
- dst_vm = self.get_vm('-incoming', 'defer', name="dst-qemu")
+ dst_vm = self.get_vm("dst-qemu")
+ dst_vm.add_args('-incoming', 'defer')
self.configure_machine(dst_vm)
dst_vm.launch()
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
index e4179d165c..12ef84281c 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -381,7 +381,7 @@ def require_device(self, devicename):
if helptxt.find(devicename) < 0:
self.skipTest('no support for device ' + devicename)
- def _new_vm(self, name, *args):
+ def _new_vm(self, name):
vm = QEMUMachine(self.qemu_bin,
name=name,
base_temp_dir=self.workdir,
@@ -394,20 +394,17 @@ def _new_vm(self, name, *args):
vm.add_args("-chardev",
f"socket,id=backdoor,path={sockpath},server=on,wait=off",
"-mon", "chardev=backdoor,mode=control")
-
- if args:
- vm.add_args(*args)
return vm
@property
def vm(self):
return self.get_vm(name='default')
- def get_vm(self, *args, name=None):
+ def get_vm(self, name=None):
if not name:
name = str(uuid.uuid4())
if self._vms.get(name) is None:
- self._vms[name] = self._new_vm(name, *args)
+ self._vms[name] = self._new_vm(name)
if self.cpu is not None:
self._vms[name].add_args('-cpu', self.cpu)
if self.machine is not None: