Commit ce3a2406d80 for php.net
commit ce3a2406d80aa8fb75c491b0634c34c0d34abc92
Author: Gina Peter Banyard <girgias@php.net>
Date: Fri Apr 17 19:04:47 2026 +0100
ext/phar/utils.c: Change if guard to assertion in phar_get_link_location()
This condition is checked before calling it at the unique call site, effectively being dead code.
An assertion is clearer.
diff --git a/ext/phar/util.c b/ext/phar/util.c
index ef07460559c..43ed4dd2482 100644
--- a/ext/phar/util.c
+++ b/ext/phar/util.c
@@ -41,9 +41,9 @@ static zend_result phar_call_openssl_signverify(bool is_sign, php_stream *fp, ze
static char *phar_get_link_location(phar_entry_info *entry) /* {{{ */
{
char *p, *ret = NULL;
- if (!entry->link) {
- return NULL;
- }
+
+ ZEND_ASSERT(entry->link);
+
if (entry->link[0] == '/') {
return estrdup(entry->link + 1);
}