Commit d5137424 for libheif
commit d5137424797c105e07e0eb016bff5a8f77896fa2
Author: Dirk Farin <dirk.farin@gmail.com>
Date: Fri May 15 14:25:03 2026 +0200
use simple constant string and fix off-by-one in bounds check (#1780)
diff --git a/libheif/plugins/decoder_libde265.cc b/libheif/plugins/decoder_libde265.cc
index 9c0820d6..d13d809e 100644
--- a/libheif/plugins/decoder_libde265.cc
+++ b/libheif/plugins/decoder_libde265.cc
@@ -45,7 +45,7 @@ static const int LIBDE265_PLUGIN_PRIORITY = 100;
#define MAX_PLUGIN_NAME_LENGTH 80
static char plugin_name[MAX_PLUGIN_NAME_LENGTH];
-static std::string version_prefix = ", version ";
+static constexpr char version_prefix[] = ", version ";
static const char* libde265_plugin_name()
{
@@ -53,8 +53,8 @@ static const char* libde265_plugin_name()
const char* libde265_version = de265_get_version();
- if (strlen(plugin_name) + strlen(libde265_version) + version_prefix.length() + 1 < MAX_PLUGIN_NAME_LENGTH) {
- strcat(plugin_name, version_prefix.c_str());
+ if (strlen(plugin_name) + strlen(libde265_version) + (sizeof(version_prefix) - 1) < MAX_PLUGIN_NAME_LENGTH) {
+ strcat(plugin_name, version_prefix);
strcat(plugin_name, libde265_version);
}