Commit da6e9520 for libheif
commit da6e9520b6d70c7465595b06b0affdf94e9ed117
Author: Dirk Farin <dirk.farin@gmail.com>
Date: Sat Apr 11 22:04:58 2026 +0200
fix error return from rotate and mirror functions
diff --git a/libheif/image-items/image_item.cc b/libheif/image-items/image_item.cc
index 3409d6fa..ae59d751 100644
--- a/libheif/image-items/image_item.cc
+++ b/libheif/image-items/image_item.cc
@@ -748,8 +748,6 @@ Result<std::shared_ptr<HeifPixelImage>> ImageItem::decode_image(const heif_decod
// --- apply image transformations
- Error error;
-
if (options.ignore_transformations == false) {
Result<std::vector<std::shared_ptr<Box>>> propertiesResult = get_properties();
if (!propertiesResult) {
@@ -762,7 +760,7 @@ Result<std::shared_ptr<HeifPixelImage>> ImageItem::decode_image(const heif_decod
if (auto rot = std::dynamic_pointer_cast<Box_irot>(property)) {
auto rotateResult = img->rotate_ccw(rot->get_rotation_ccw(), m_heif_context->get_security_limits());
if (!rotateResult) {
- return error;
+ return rotateResult.error();
}
img = *rotateResult;
@@ -773,7 +771,7 @@ Result<std::shared_ptr<HeifPixelImage>> ImageItem::decode_image(const heif_decod
auto mirrorResult = img->mirror_inplace(mirror->get_mirror_direction(),
get_context()->get_security_limits());
if (!mirrorResult) {
- return error;
+ return mirrorResult.error();
}
img = *mirrorResult;
}