Commit db52193355 for qemu.org
commit db52193355cf75394a39ca9f70b1325d4bbe18d6
Author: Trieu Huynh <vikingtc4@gmail.com>
Date: Tue Mar 17 22:47:33 2026 +0900
plugins/api-system: Handle migrate_add_blocker() failure
migrate_add_blocker() can fail (e.g. if migration is already in
progress), in which case it returns a negative value and populates
its errp argument with the reason.
The previous code ignored the return value. Pass &error_fatal so
that on failure QEMU exits cleanly with an informative error message
rather than continuing in an inconsistent state.
Resolves: CID 1645470
Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Tested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260317134733.126584-1-vikingtc4@gmail.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/plugins/api-system.c b/plugins/api-system.c
index 9a70b9caa6..fbf905cd63 100644
--- a/plugins/api-system.c
+++ b/plugins/api-system.c
@@ -108,7 +108,7 @@ const void *qemu_plugin_request_time_control(void)
has_control = true;
error_setg(&migration_blocker,
"TCG plugin time control does not support migration");
- migrate_add_blocker(&migration_blocker, NULL);
+ migrate_add_blocker(&migration_blocker, &error_fatal);
return &has_control;
}
return NULL;