Commit e4317bc4 for tesseract
commit e4317bc475e56062c37a9c190efe60ab7db899ea
Author: Stefan Weil <sw@weilnetz.de>
Date: Sun Aug 9 15:08:45 2026 +0200
Fix CID 1438662 (String not null terminated)
fread does not write a null terminator, so the buffer was only
properly terminated because it had been zero-initialized. Terminate
it explicitly after reading.
Assisted-by: OpenCode / big-pickle (opencode)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
diff --git a/unittest/fileio_test.cc b/unittest/fileio_test.cc
index 798b4e9c..b976c968 100644
--- a/unittest/fileio_test.cc
+++ b/unittest/fileio_test.cc
@@ -26,9 +26,6 @@ TEST(FileTest, JoinPath) {
TEST(OutputBufferTest, WriteString) {
const int kMaxBufSize = 128;
char buffer[kMaxBufSize];
- for (char &i : buffer) {
- i = '\0';
- }
FILE *fp = tmpfile();
CHECK(fp != nullptr);
@@ -37,9 +34,9 @@ TEST(OutputBufferTest, WriteString) {
output->WriteString("world!");
rewind(fp);
- auto s = "Hello world!";
- fread(buffer, strlen(s), 1, fp);
- EXPECT_STREQ(s, buffer);
+ size_t read_size = fread(buffer, 1, kMaxBufSize - 1, fp);
+ buffer[read_size] = '\0';
+ EXPECT_STREQ("Hello world!", buffer);
}
TEST(InputBufferTest, Read) {